[bisq-network/bisq] Provide more offer & contract detail available to CLI (#5357)
Stan
notifications at github.com
Thu Mar 25 23:27:53 CET 2021
This change adds offer and trade contract detail to the API's Offer and Trade protos, and improves CLI output formatting.
- Appended missing fields to `OfferInfo` proto message:
uint64 sellerSecurityDeposit = 20;
string offerFeePaymentTxId = 21;
uint64 txFee = 22;
uint64 makerFee = 23;
- Added new api proto messages `ContractInfo` and `PaymentAccountPayloadInfo`.
Lighterweight protos are needed because core Trade/Contract classes are not visible to CLI.
- Appended `ContractInfo` field to api proto message `TradeInfo`.
- Added proto / model converters for `ContractInfo` and `PaymentAccountPayloadInfo`, and adjusted `OfferInfo` & `TradeInfo`.
- Improved CLI output formatting. Added more trade detail to CLI's `gettrade` output, and prepared to support BTC/BSQ trading pair. _Note a reviewer is advised to look at the CLI outout formatting class files instead getting bogged down in the many commit changes._
This is the 2bd PR in a series, with the goal of supporting the BTC/BSQ trading pair.
PR https://github.com/bisq-network/bisq/pull/5356 must be reviewed/merge before this one.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/5357
-- Commit Summary --
* Add api method createcryptopaymentacct
* Add cli side help for createcryptopaymentacct
* Provide more offer & contract detail available to CLI.
-- File Changes --
M cli/src/main/java/bisq/cli/CliMain.java (23)
M cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (9)
M cli/src/main/java/bisq/cli/CurrencyFormat.java (46)
A cli/src/main/java/bisq/cli/DirectionFormat.java (60)
M cli/src/main/java/bisq/cli/GrpcClient.java (49)
M cli/src/main/java/bisq/cli/Method.java (1)
M cli/src/main/java/bisq/cli/TableFormat.java (166)
M cli/src/main/java/bisq/cli/TradeFormat.java (145)
M cli/src/main/java/bisq/cli/opts/ArgumentList.java (1)
A cli/src/main/java/bisq/cli/opts/CreateCryptoCurrencyPaymentAcctOptionParser.java (75)
M cli/src/main/java/bisq/cli/opts/MethodOpts.java (1)
M cli/src/main/java/bisq/cli/opts/OptLabel.java (1)
M cli/src/test/java/bisq/cli/opt/OptionParsersTest.java (89)
M core/src/main/java/bisq/core/api/CoreApi.java (8)
M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (50)
M core/src/main/java/bisq/core/api/CoreWalletsService.java (20)
A core/src/main/java/bisq/core/api/model/ContractInfo.java (126)
M core/src/main/java/bisq/core/api/model/OfferInfo.java (52)
M core/src/main/java/bisq/core/api/model/PaymentAccountForm.java (10)
A core/src/main/java/bisq/core/api/model/PaymentAccountPayloadInfo.java (76)
M core/src/main/java/bisq/core/api/model/TradeInfo.java (63)
M core/src/main/java/bisq/core/api/model/TxInfo.java (22)
A core/src/main/resources/help/createcryptopaymentacct-help.txt (39)
M daemon/src/main/java/bisq/daemon/grpc/GrpcPaymentAccountsService.java (37)
M proto/src/main/proto/grpc.proto (47)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/5357.patch
https://github.com/bisq-network/bisq/pull/5357.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5357
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210325/456bd84d/attachment.htm>
More information about the bisq-github
mailing list