[bisq-network/bisq] Add BTC/BSQ pair offer & trading tests (#5359)

[Stan]

And fixed maker and taker fees in trade output.

Also tidy'd up some test cases:

- Fixed some test names
- Added comments
- Loosened some trade state/phase asserts
- Removed direction string literals
- Made long literals more readable
- Right justified offer amount and volume columns in CLI output
- Added some offer and trade logging to see CLI output formatting

This is the 3rd PR in a series, with the goal of supporting the BTC/BSQ trading pair.
PR https://github.com/bisq-network/bisq/pull/5357 must be reviewed/merge before this one.

Here is the improved CLI output for a Buy BSQ (Sell BTC) offer:

```
Buy/Sell            Price in BTC for 1 BSQ           BTC(min - max)       BSQ(min - max)  Payment Method  Creation Date (UTC)   ID
Buy BSQ (Sell BTC)              0.00003500  0.07500000 - 0.15000000  2,142.86 - 4,285.71  Altcoins        2021-03-25T22:50:30Z  SENGP7Q-d3744afa-847d-4986-816b-e1e993e4f05d-159 
```    


Here is `gettrade` output for BSQ buyer as maker:

```
ID       My Role             Price in BTC for 1 BSQ  Amount(BSQ)  Tx Fee(BTC)   Maker Fee(BSQ)  Deposit Published  Deposit Confirmed  Buyer Cost(BTC)  BSQ Sent  BSQ Received  Payout Published  Withdrawn  
SENGP7Q  BSQ buyer as maker              0.00003500     4,285.71   0.00013975             0.08  YES                YES                     0.15000000  YES       YES           YES               NO
```        


Here is `gettrade` output for BSQ seller as taker:

```
ID       My Role              Price in BTC for 1 BSQ  Amount(BSQ)  Tx Fee(BTC)   Taker Fee(BSQ)  Deposit Published  Deposit Confirmed  Buyer Cost(BTC)  BSQ Sent  BSQ Received  Payout Published  Withdrawn  
SENGP7Q  BSQ seller as taker              0.00003500     4,285.71   0.00009116             0.23  YES                YES                     0.15000000  YES       YES           YES               NO 
```   


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5359

-- Commit Summary --

  * Add api method createcryptopaymentacct
  * Add cli side help for createcryptopaymentacct
  * Provide more offer & contract detail available to CLI.
  * Add BTC/BSQ pair offer & trading tests

-- File Changes --

    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (3)
    M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (16)
    M apitest/src/test/java/bisq/apitest/method/offer/CancelOfferTest.java (5)
    A apitest/src/test/java/bisq/apitest/method/offer/CreateBSQOffersTest.java (256)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (99)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (129)
    M apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java (16)
    M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (15)
    A apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (320)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (50)
    A apitest/src/test/java/bisq/apitest/method/trade/TakeSellBSQOfferTest.java (323)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (56)
    M apitest/src/test/java/bisq/apitest/scenario/OfferTest.java (15)
    M apitest/src/test/java/bisq/apitest/scenario/TradeTest.java (24)
    M apitest/src/test/java/bisq/apitest/scenario/bot/BotClient.java (6)
    M apitest/src/test/java/bisq/apitest/scenario/bot/RandomOffer.java (10)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/BotProtocol.java (8)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/MakerBotProtocol.java (3)
    M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/TakerBotProtocol.java (12)
    M cli/src/main/java/bisq/cli/CliMain.java (23)
    M cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (9)
    M cli/src/main/java/bisq/cli/CurrencyFormat.java (46)
    A cli/src/main/java/bisq/cli/DirectionFormat.java (60)
    M cli/src/main/java/bisq/cli/GrpcClient.java (49)
    M cli/src/main/java/bisq/cli/Method.java (1)
    M cli/src/main/java/bisq/cli/TableFormat.java (166)
    M cli/src/main/java/bisq/cli/TradeFormat.java (145)
    M cli/src/main/java/bisq/cli/opts/ArgumentList.java (1)
    A cli/src/main/java/bisq/cli/opts/CreateCryptoCurrencyPaymentAcctOptionParser.java (75)
    M cli/src/main/java/bisq/cli/opts/MethodOpts.java (1)
    M cli/src/main/java/bisq/cli/opts/OptLabel.java (1)
    M cli/src/test/java/bisq/cli/opt/OptionParsersTest.java (89)
    M core/src/main/java/bisq/core/api/CoreApi.java (8)
    M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (50)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (20)
    A core/src/main/java/bisq/core/api/model/ContractInfo.java (126)
    M core/src/main/java/bisq/core/api/model/OfferInfo.java (52)
    M core/src/main/java/bisq/core/api/model/PaymentAccountForm.java (10)
    A core/src/main/java/bisq/core/api/model/PaymentAccountPayloadInfo.java (76)
    M core/src/main/java/bisq/core/api/model/TradeInfo.java (63)
    M core/src/main/java/bisq/core/api/model/TxInfo.java (22)
    A core/src/main/resources/help/createcryptopaymentacct-help.txt (39)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcPaymentAccountsService.java (37)
    M proto/src/main/proto/grpc.proto (47)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5359.patch
https://github.com/bisq-network/bisq/pull/5359.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5359
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210325/d406f388/attachment-0001.htm>