[bisq-network/bisq] Remove the apparent link for cases where the trade is not available for mediators (#5354)

Christoph Atteneder notifications at github.com
Fri Mar 26 08:45:04 CET 2021


@ripcurlx commented on this pull request.



> -                                    field = new HyperlinkWithIcon(item.getShortTradeId());
                                     Optional<Trade> tradeOptional = tradeManager.getTradeById(item.getTradeId());
                                     if (tradeOptional.isPresent()) {
+                                        field = new HyperlinkWithIcon(item.getShortTradeId());
                                         field.setMouseTransparent(false);
                                         field.setTooltip(new Tooltip(Res.get("tooltip.openPopupForDetails")));
                                         field.setOnAction(event -> tradeDetailsWindow.show(tradeOptional.get()));
                                     } else {
-                                        field.setMouseTransparent(true);
+                                        setText(item.getShortTradeId());
                                     }

The hyperlink is needed for the DisputeClientView that is extending DisputeView. So if a trade is available it should link to the trade details popup.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5354#discussion_r602072964
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210326/bfe32123/attachment-0001.htm>


More information about the bisq-github mailing list