[bisq-network/bisq] Fix ClassCastError in Portfolio History Summary Popup (#5363)

jmacxx notifications at github.com
Fri Mar 26 22:20:43 CET 2021


Fix another ClassCastError.

There is a `Show Summary` window which also has the same issue that PR #5358 fixed in Portfolio History.

![image](https://user-images.githubusercontent.com/47253594/112693714-1755ed80-8e4f-11eb-8a9c-f9994dba872e.png)


![image](https://user-images.githubusercontent.com/47253594/112693196-34d68780-8e4e-11eb-8bcd-b6a9e93e405b.png)

    Mar-26 15:49:37.872 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Uncaught Exception from thread JavaFX Application Thread 
    Mar-26 15:49:37.872 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableMessage= bisq.core.offer.OpenOffer cannot be cast to bisq.core.trade.Trade 
    Mar-26 15:49:37.872 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableClass= class java.lang.ClassCastException 
    Mar-26 15:49:37.872 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Stack trace:
    java.lang.ClassCastException: bisq.core.offer.OpenOffer cannot be cast to bisq.core.trade.Trade
	    at bisq.desktop.main.portfolio.closedtrades.ClosedTradesDataModel.lambda$getTotalTxFee$7(ClosedTradesDataModel.java:166)

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5363

-- Commit Summary --

  * Fix ClassCastError in Portfolio History Summary Popup

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesDataModel.java (5)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5363.patch
https://github.com/bisq-network/bisq/pull/5363.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5363
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210326/53a12aa9/attachment-0001.htm>


More information about the bisq-github mailing list