[bisq-network/bisq] Fix focus issue when enter key used to edit offer (#5473)

jmacxx notifications at github.com
Fri May 7 06:40:57 CEST 2021


If an offer percent is edited and submitted using the `enter` key to accept the changes, the **next time** an offer is edited its price percentage field is always shown as 0%.

Using `enter`, the control with focus is not the submit button, whereas it always is when the mouse is used.  However, the next time the edit offer screen is shown, it does not initialize correctly if the focus is not on the submit button (the dialog is cached, so the previous controls state are still in effect).  Various initialization events get fired that reset the price percentage field to 0%, overwriting the value stored in the data object.  The initialization process for the edit offer screen is the most difficult GUI code in Bisq, so the simplest way to fix this is to place focus on the submit button when its action is invoked.

Note: issue happens in all releases <= 1.6.4
Fixes #5460
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5473

-- Commit Summary --

  * fix issue #5460 (when enter key used, focus is wrong)

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferView.java (1)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5473.patch
https://github.com/bisq-network/bisq/pull/5473.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5473
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210506/6b18f4b9/attachment-0001.htm>


More information about the bisq-github mailing list