[bisq-network/bisq] Show offer type (buy/sell) i Market/Trades (#5466)
jmacxx
notifications at github.com
Fri May 7 19:28:54 CEST 2021
TradeStatistics was re-architected October 2020, removing data which consisted a privacy leak. https://github.com/bisq-network/bisq/issues/3893 https://github.com/bisq-network/bisq/pull/4611 Part of the re-architecting was to reduce the data size since it was causing performance issues.
I am not sure if adding data to TradeStatistics causes a hard fork, meaning TradeStatistics3 would have to become TradeStatistics4. (@chimp1984 would know). There was a prior request by @pazza83 to add "percentage deviation from market" into TradeStatistics that has not been done either, for the same reasons. I asked a [question about it](https://github.com/bisq-network/bisq/issues/4641#issuecomment-717223569) which went unanswered.
IMHO it is costly to change TradeStatistics and there would have to be really good reasons to justify the time and expense, and the maintainers would have to approve such a request first.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/discussions/5466#discussioncomment-711009
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210507/94b88644/attachment.htm>
More information about the bisq-github
mailing list