[bisq-network/bisq] Speed up "Synchronizing DAO" by ~30% (#5484)

chimp1984 notifications at github.com
Wed May 12 15:08:41 CEST 2021


@chimp1984 requested changes on this pull request.

@cd2357 Thanks for working on that.
There is missing the chache update when a new block is added in `onNewBlockWithEmptyTxs`.
Maybe its better to create explicit methods for `daoState.getBlocks().addAll` and `daoState.getBlocks().add` in DaoStateService.

> @@ -109,6 +109,8 @@ public static DaoState getClone(DaoState daoState) {
     @JsonExclude
     private transient final Map<String, Tx> txCache; // key is txId
     @JsonExclude
+    private transient final Map<Integer, Block> blockHeightCache; // key is block height

Maybe better name is blocksByHeight.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5484#pullrequestreview-657839939
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210512/94509120/attachment.htm>


More information about the bisq-github mailing list