[bisq-network/bisq] Speed up "Synchronizing DAO" by ~30% (#5484)
chimp1984
notifications at github.com
Mon May 17 02:21:27 CEST 2021
@chimp1984 approved this pull request.
Beside the small naming issue utACK
> @JsonExclude
- private transient final Set<String> blockHashCache;
+ private transient final Set<String> blocksByHash; // Blocks indexed by hash
With blocksByHash I would expect a map with hash as key and blocks as value. For a set I would use 'blockHashes'
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5484#pullrequestreview-660482841
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210516/daf35c1b/attachment.htm>
More information about the bisq-github
mailing list