[bisq-network/bisq] Return correct security deposit percentage size/minimum deposit when cloning an offer (#5485)

[Christoph Atteneder]

@ripcurlx requested changes on this pull request.

NACK

> +        if (offer.getBuyerSecurityDeposit().value == Restrictions.getMinBuyerSecurityDepositAsCoin().getValue())
+            setBuyerSecurityDeposit(Restrictions.getMinBuyerSecurityDepositAsPercent());
+        else
+            setBuyerSecurityDeposit(CoinUtil.getAsPercentPerBtc(offer.getBuyerSecurityDeposit(), offer.getAmount()));
+

NIT: we decided to always use brackets, even for one-liners as we had issues in the past.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5485#pullrequestreview-660633429
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210517/26774ca7/attachment.htm>