[bisq-network/bisq] Add Account owner full name field to Uphold payment method (#5500)

Christoph Atteneder notifications at github.com
Tue May 18 16:31:54 CEST 2021


@ripcurlx requested changes on this pull request.

NACK - Please see my comment regarding proto changes

> +    string account_owner = 1;
+    string account_id = 2;

Never change the IDs of the old values, use incremented ones for new fields (`string account_owner=2`). This would cause issues with existing accounts. Please also run some backwards comp. tests with this change to be sure it works as expected.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5500#pullrequestreview-662165398
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210518/1ab1c238/attachment.htm>


More information about the bisq-github mailing list