[bisq-network/bisq] Add Account owner full name field to Uphold payment method (#5500)

[Christoph Atteneder]

@ripcurlx requested changes on this pull request.

NACK - proto and backwrd. comp. are looking fine now, just a couple of minor adjustments needed.

> @@ -44,4 +44,13 @@ public void setAccountId(String accountId) {
     public String getAccountId() {
         return ((UpholdAccountPayload) paymentAccountPayload).getAccountId();
     }
+
+    public String getAccountOwner() {
+        return ((UpholdAccountPayload) paymentAccountPayload).getAccountOwner();
+    }
+
+    public void setAccountOwner(String accountOwner) {
+        if (accountOwner == null) accountOwner = "";

Please use brackets around this conditional.

> @@ -44,4 +44,13 @@ public void setAccountId(String accountId) {
     public String getAccountId() {
         return ((UpholdAccountPayload) paymentAccountPayload).getAccountId();
     }
+
+    public String getAccountOwner() {

Is there a reason why you don't display the account owner in `addFormForDisplayAccount`?

> +                if (accountOwner.equals("")) {
+                    return
+                            Res.get("payment.account") + ": " + accountId + "\n" +
+                                    Res.get("payment.account.owner") + ": N/A";
+                } else {
+                    return
+                            Res.get("payment.account") + ": " + accountId + "\n" +
+                                    Res.get("payment.account.owner") + ": " + accountOwner;
+                }

Could you please decrease the intention

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5500#pullrequestreview-662880446
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210519/7b36010b/attachment.htm>