[bisq-network/bisq] Payment account factory test (#5530)

[bhuan007]

Added a new test class called PaymentAccountFactoryTest.java under bisq/core/src/test/java/bisq.core/payment

I noticed that there are currently no test cases for the PaymentAccountFactory, so I added some test cases to make sure the returned accounts are correct.

You will notice that there are some commented out PaymentMethods, these payment methods do not pass the test.

I noticed that the failing payment methods extend CountryBasedPaymentAccount, which is something to look into.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5530

-- Commit Summary --

  * gpg test
  * added PaymentAccountFactoryTest under bisq.core/test/payment
  * Fixed PaymentAccountFactoryTest

-- File Changes --

    A core/src/test/java/bisq/core/payment/PaymentAccountFactoryTest.java (109)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5530.patch
https://github.com/bisq-network/bisq/pull/5530.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5530
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210525/85a83c4a/attachment.htm>