[bisq-network/bisq] Fix security deposit in duplicate offer when minimum deposit is used (#5535)

jmacxx notifications at github.com
Thu May 27 18:22:32 CEST 2021


@jmacxx commented on this pull request.



>  
     // Percentage value of buyer security deposit. E.g. 0.01 means 1% of trade amount
     protected final DoubleProperty buyerSecurityDeposit = new SimpleDoubleProperty();
 
+    protected final StringProperty buyerSecurityDepositInBTC = new SimpleStringProperty();

`buyerSecurityDepositInBTC` is already used by a listener in MutableOfferView.java.  Its odd that github diff is showing the line above as "new code", as I think @BtcContributor only added the keyword `protected` here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5535#discussion_r640779802
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210527/155242fe/attachment.htm>


More information about the bisq-github mailing list