[bisq-network/bisq] Fix security deposit in duplicate offer when minimum deposit is used (#5535)

jmacxx notifications at github.com
Thu May 27 18:37:26 CEST 2021


@jmacxx commented on this pull request.



>  
     // Percentage value of buyer security deposit. E.g. 0.01 means 1% of trade amount
     protected final DoubleProperty buyerSecurityDeposit = new SimpleDoubleProperty();
 
+    protected final StringProperty buyerSecurityDepositInBTC = new SimpleStringProperty();

NACK. -> upon testing this PR it does not fix the case of duplicate on offers that had 0.006 security deposit. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5535#discussion_r640790901
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210527/36a42397/attachment.htm>


More information about the bisq-github mailing list