[bisq-network/bisq] Add Account owner full name field to Uphold payment method (#5500)

Christoph Atteneder notifications at github.com
Mon May 31 21:19:45 CEST 2021


@ripcurlx commented on this pull request.



>      }
 
     @Override
     public String getPaymentDetailsForTradePopup() {
-        return getPaymentDetails();
+        if (accountOwner.equals("")) {

I don't think we need the extra null check for `accountOwner` in this case as it is always initialized with `""`. Probably `accountOwner.isEmpty()` would be more readable for this backwardscomp. check. @BtcContributor WDYT?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5500#discussion_r642647357
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210531/091feaaf/attachment.htm>


More information about the bisq-github mailing list