[bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR #5770)

[chimp1984]

@chimp1984 commented on this pull request.



> @@ -96,7 +96,7 @@ public static TradeStatistics2 from(Trade trade,
         Offer offer = trade.getOffer();
         checkNotNull(offer, "offer must not ne null");
         checkNotNull(trade.getTradeAmount(), "trade.getTradeAmount() must not ne null");
-        OfferPayload offerPayload = offer.getOfferPayload();
+        OfferPayload offerPayload = offer.getOfferPayload().orElseThrow();

It is the normal Bisq offer (not BSQ swap) the Optional is expected to be present as that class is not used by BSQ swap

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#discussion_r741142848
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211102/f47a4d98/attachment-0001.htm>