[bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR #5770)

[chimp1984]

@chimp1984 commented on this pull request.



> @@ -414,7 +414,7 @@ public void validateBasicOfferData(PaymentMethod paymentMethod, String currencyC
     // Immutable fields are sourced from the original openOffer param.
     public OfferPayload getMergedOfferPayload(OpenOffer openOffer,
                                               MutableOfferPayloadFields mutableOfferPayloadFields) {
-        OfferPayload original = openOffer.getOffer().getOfferPayload();
+        OfferPayload original = openOffer.getOffer().getOfferPayload().orElseThrow();

It is the normal Bisq offer (not BSQ swap) the Optional is expected to be present as that class is not used by BSQ swap

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#discussion_r741143751
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211102/bf70ba1f/attachment.htm>