[bisq-network/bisq] Avoid that outdated donation and fee addresses are used. (PR #5764)

[chimp1984]

> Could be good to define the hardcoded addresses in `Config.java` since they are used in more than one place, and to avoid having them sprinkled through the code, see: `Param.java, DaoFacade.java, DelayedPayoutAddressProvider.java, TxValidatorTest.java`
> 
> ```
> public static final String TESTNET_DONATION_ADDRESS = "2N4mVTpUZAnhm9phnxB7VrHB4aBhnWrcUrV";
> public static final String REGTEST_DONATION_ADDRESS = "2MzBNTJDjjXgViKBGnatDU3yWkJ8pJkEg9w";
> public static final String INITIAL_DONATION_ADDRESS = "1BVxNn3T12veSK6DgqwU4Hdn7QHcDDRag7";
> public static final String LATEST_DONATION_ADDRESS = "38bZBj5peYS3Husdz7AH3gEUiUbYRD951t";
> public static final String BURNINGMAN_2019 = "3EtUWqsGThPtjwUczw27YCo6EWvQdaPUyp";
> public static final String BURNINGMAN_2 = "3A8Zc1XioE2HRzYfbb5P8iemCS72M6vRJV";
> public static final String BURNINGMAN_3 = "34VLFgtFKAtwTdZ5rengTT2g2zC99sWQLC";
> ```

Yes agree. I will update that PR once the other PRs are merged...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5764#issuecomment-957883054
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211102/1f2331e9/attachment-0001.htm>