[bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)

[Christoph Atteneder]

I just tried both scenarios to Buy and Sell BTC for BSQ  successfully! 🚀  These are my comments for the UI parts of the trade process.

1) I think it would be good to mention in the popup or in wiki article linked in the `NEW` popup (https://bisq.wiki/BSQ_swaps), that a hidden BSQ Swap account is created: `BSQ Swap (BSQ, BSQ Swap)`. It wasn't a big hurdle when I tried to create a Buy BTC offer that I need to select the new BSQ Swap account, but I think it would be good to mention that this account is created automatically and that it is not visible in the account section as all other accounts.

![Bildschirmfoto 2021-11-03 um 10 16 23](https://user-images.githubusercontent.com/170962/140039555-86b4ee63-ecdc-4627-bf4b-ac2ce466983e.png)

2) When creating a Buy BTC (Sell BSQ) offer I recognized that after creating the offer the filter by currency combobox was selected and open (I have the same open issue in the buy BSQ branch). Is this a known problem?
![Bildschirmfoto 2021-11-03 um 10 21 26](https://user-images.githubusercontent.com/170962/140039815-7740dc15-a6a5-424d-ba2b-2caf25defdf8.png)

3) I'm not sure if it is necessary to change the label of the tab to `Create BSQ Swap offer` from `Create offer` when a BSQ swap account is selected, as it is also placed under `My open offers`. 
![Bildschirmfoto 2021-11-03 um 10 20 23](https://user-images.githubusercontent.com/170962/140040110-3918434c-aaaf-4b35-a912-55ea8abaf5cd.png)

4) When taking a BSQ swap offer, after taking the offer successfully I get following success message.

![Bildschirmfoto 2021-11-03 um 10 24 50](https://user-images.githubusercontent.com/170962/140040400-998a9a7d-00d3-4a34-8f11-d4777d5ad85b.png)

This leaves me with the impression that the trade is already completed.  I was expecting in that case that I'll find  the trade in my portfolio > history tab. But as mentioned in the overlay above there is a new BSQ SWAP TRADES tab (Should be in lower case to match other navigation references: `BSQ swap trades`).  So I though that this is because the transaction doesn't have already a block confirmation.

![Bildschirmfoto 2021-11-03 um 10 25 43](https://user-images.githubusercontent.com/170962/140040902-d86bb599-d39e-4187-8d28-78d0e36394b2.png)
![Bildschirmfoto 2021-11-03 um 10 26 37](https://user-images.githubusercontent.com/170962/140040916-ee65f0d9-216f-476b-9ebc-1ab584dd2c9c.png)
After sufficient confirmations the tab is still there. Is there a reason why we didn't call this tab `Open BSQ swap trades` and move it to history after the trade has at least one block confirmation? I personally would appreciate having all my trades in one history, or is there a technical reason for this?






-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5775#issuecomment-958805612
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211103/7c59629b/attachment-0001.htm>