[bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)

[chimp1984]

@ripcurlx 
Re 1: The BSQ account creation is mentioned in the news popup:
<img width="618" alt="Screenshot 2021-11-03 at 12 03 01" src="https://user-images.githubusercontent.com/54558767/140049361-a5aa689d-52a8-41b3-a28b-94b1d2eb74ab.png">

Re 2:
I cannot reproduce that anymore, but had that issue in the past. It seems some bug with the combobox and with focus. I added a requestFocus call but might be that there are timing/race conditions where the combobox still wins... Maybe some delayed requestFocus can make it more reliable.

Re 3:
Yes, no strong opinion here. But adding a bit explicit naming might help that people understand its different to normal offers/trades. For open offers there is no beavioural difference beside that edit offer is disabled and the disable/enable column which reacts to wallet balance. So that was rather easy to add to the existing one. For trades I think its more justified to add another tab as the process of pending trades->closed trades is not happening for BSQ swaps. 
To add too many tabs might overload a bit the UI and I think its more convenient to have all offers in one place. 

Re 4:
Yes I can rename "BSQ SWAP TRADES".
The trade is basically completed. You cannot do anything to stop it from confirming beside doing a doublespend.
I think we should not give the impression the trade is still in a pending state just because its not confirmed. For BSQ though the funds don't show up before confirmations. So yes that could be improved...
To add the trade after confrimation to history should be possible but comes with some effort. I would prefer to do that in a new PR if considered important.

Re: "I also just recognized that all altcoin/bsq swap offers have the deviation value greyed out, but not Fiat offers. This is a live problem already."
Yes might need a review...

I will add a commit for the rename and add another delayed requestFocus (hope that helps). For the BSQ swap account issue I think it should be covered in the news popup suficiently and maybe we can add/emphasise it in the wiki (have not looked up how its there). If you have a concrete suggestion where to add it additionally let me know.
But would prefer to get that merged and add other changes in new PRs.


 

 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5775#issuecomment-958941101
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211103/e3bc72f1/attachment.htm>