[bisq-network/bisq] Deprecate and replace hard-coded CLI console output formatters (PR #5812)
Stan
notifications at github.com
Sun Nov 7 18:11:27 CET 2021
This PR adds a new CLI console output formatting api, which dynamically formats and justifies console output via a table of columns, populated from protobuf messages. New test cases are included to verify there are no differences between the old console output "api" and the new one.
Some refactoring of apitest trading test cases was done to reduce class size.
Based on PR https://github.com/bisq-network/bisq/pull/5811
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/5812
-- Commit Summary --
* <a href="https://github.com/bisq-network/bisq/pull/5812/commits/eb234bf93a2dde6c00946c42aa14bd87d205c6d9">Remove apitest's create bsq-swap account method</a>
* <a href="https://github.com/bisq-network/bisq/pull/5812/commits/531db1eac4ad3c05527211e137f388c3ec5b7ee1">Do not publish altcoin acct age witness data</a>
* <a href="https://github.com/bisq-network/bisq/pull/5812/commits/edd01418ca39fe6704ad4e07b3be39487235a618">Remove fields/methods/logic for creating redundant bsq-swap accounts</a>
* <a href="https://github.com/bisq-network/bisq/pull/5812/commits/19436c3e2fc8b1fc69fb2511dfb119bbd7498166">Add new bisq.cli.table classes</a>
* <a href="https://github.com/bisq-network/bisq/pull/5812/commits/08d16e60402fb9a81a22c0422dbbb5cb29e66ab7">Deprecate old CLI console output formatters</a>
* <a href="https://github.com/bisq-network/bisq/pull/5812/commits/034110482374c9672d40302d807c4543ff87da96">Adjust CLI classes to new console output api</a>
* <a href="https://github.com/bisq-network/bisq/pull/5812/commits/ec09d39832afd7866c6c29b5c91f896461fae31d">Adjust apitest cases to new CLI console output api</a>
* <a href="https://github.com/bisq-network/bisq/pull/5812/commits/1d403e7a4287999a23f000ea94df821622013657">Add CLI test dependency to check console output diffs, and tests</a>
* <a href="https://github.com/bisq-network/bisq/pull/5812/commits/eb57b7e75e2569788df752a7cbfb7e968d70a5c0">Merge branch '01-use-default-bsq-swap-acct' into 02-cli-console-formatting-api</a>
-- File Changes --
M apitest/src/main/java/bisq/apitest/config/ApiTestConfig.java (3)
M apitest/src/test/java/bisq/apitest/method/MethodTest.java (16)
M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (49)
M apitest/src/test/java/bisq/apitest/method/offer/BsqSwapOfferTest.java (4)
M apitest/src/test/java/bisq/apitest/method/offer/CreateBSQOffersTest.java (44)
M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (18)
M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (19)
M apitest/src/test/java/bisq/apitest/method/offer/EditOfferTest.java (98)
M apitest/src/test/java/bisq/apitest/method/payment/CreatePaymentAccountTest.java (35)
M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (179)
M apitest/src/test/java/bisq/apitest/method/trade/BsqSwapTradeTest.java (23)
M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (185)
M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (187)
M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferWithNationalBankAcctTest.java (167)
M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBSQOfferTest.java (205)
M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (179)
M apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java (58)
M apitest/src/test/java/bisq/apitest/method/wallet/BtcWalletTest.java (23)
M apitest/src/test/java/bisq/apitest/scenario/LongRunningBsqSwapTest.java (1)
M apitest/src/test/java/bisq/apitest/scenario/LongRunningTradesTest.java (2)
M apitest/src/test/java/bisq/apitest/scenario/OfferTest.java (2)
M apitest/src/test/java/bisq/apitest/scenario/TradeTest.java (9)
M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/MakerBotProtocol.java (2)
M apitest/src/test/java/bisq/apitest/scenario/bot/protocol/TakerBotProtocol.java (2)
M build.gradle (2)
M cli/src/main/java/bisq/cli/CliMain.java (67)
M cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (1)
M cli/src/main/java/bisq/cli/CryptoCurrencyUtil.java (5)
M cli/src/main/java/bisq/cli/CurrencyFormat.java (42)
M cli/src/main/java/bisq/cli/DirectionFormat.java (1)
M cli/src/main/java/bisq/cli/GrpcClient.java (8)
A cli/src/main/java/bisq/cli/OfferFormat.java (309)
M cli/src/main/java/bisq/cli/TableFormat.java (233)
M cli/src/main/java/bisq/cli/TradeFormat.java (5)
M cli/src/main/java/bisq/cli/TransactionFormat.java (1)
M cli/src/main/java/bisq/cli/opts/CreateCryptoCurrencyPaymentAcctOptionParser.java (14)
M cli/src/main/java/bisq/cli/opts/OptLabel.java (1)
M cli/src/main/java/bisq/cli/request/OffersServiceRequest.java (9)
M cli/src/main/java/bisq/cli/request/PaymentAccountsServiceRequest.java (18)
M cli/src/main/java/bisq/cli/request/TradesServiceRequest.java (4)
M cli/src/main/java/bisq/cli/request/WalletsServiceRequest.java (5)
A cli/src/main/java/bisq/cli/table/Table.java (155)
A cli/src/main/java/bisq/cli/table/builder/AbstractTableBuilder.java (47)
A cli/src/main/java/bisq/cli/table/builder/AbstractTradeListBuilder.java (303)
A cli/src/main/java/bisq/cli/table/builder/AbstractTradeTableBuilder.java (106)
A cli/src/main/java/bisq/cli/table/builder/AddressBalanceTableBuilder.java (81)
A cli/src/main/java/bisq/cli/table/builder/BsqBalanceTableBuilder.java (78)
A cli/src/main/java/bisq/cli/table/builder/BtcBalanceTableBuilder.java (73)
A cli/src/main/java/bisq/cli/table/builder/FailedTradeTableBuilder.java (49)
A cli/src/main/java/bisq/cli/table/builder/OfferTableBuilder.java (280)
A cli/src/main/java/bisq/cli/table/builder/OpenTradeTableBuilder.java (47)
A cli/src/main/java/bisq/cli/table/builder/PaymentAccountTableBuilder.java (74)
A cli/src/main/java/bisq/cli/table/builder/TableBuilder.java (70)
A cli/src/main/java/bisq/cli/table/builder/TableBuilderConstants.java (83)
A cli/src/main/java/bisq/cli/table/builder/TableType.java (35)
A cli/src/main/java/bisq/cli/table/builder/TradeDetailTableBuilder.java (92)
A cli/src/main/java/bisq/cli/table/builder/TradeTableColumnSupplier.java (263)
A cli/src/main/java/bisq/cli/table/builder/TransactionTableBuilder.java (103)
A cli/src/main/java/bisq/cli/table/column/AbstractColumn.java (86)
A cli/src/main/java/bisq/cli/table/column/AltcoinColumn.java (98)
A cli/src/main/java/bisq/cli/table/column/BooleanColumn.java (131)
A cli/src/main/java/bisq/cli/table/column/BtcColumn.java (48)
A cli/src/main/java/bisq/cli/table/column/Column.java (122)
A cli/src/main/java/bisq/cli/table/column/DoubleColumn.java (93)
A cli/src/main/java/bisq/cli/table/column/FiatColumn.java (91)
A cli/src/main/java/bisq/cli/table/column/Iso8601DateTimeColumn.java (64)
A cli/src/main/java/bisq/cli/table/column/LongColumn.java (93)
A cli/src/main/java/bisq/cli/table/column/MixedPriceColumn.java (57)
A cli/src/main/java/bisq/cli/table/column/MixedTradeFeeColumn.java (59)
A cli/src/main/java/bisq/cli/table/column/MixedVolumeColumn.java (73)
A cli/src/main/java/bisq/cli/table/column/NumberColumn.java (32)
A cli/src/main/java/bisq/cli/table/column/SatoshiColumn.java (72)
A cli/src/main/java/bisq/cli/table/column/StringColumn.java (102)
A cli/src/main/java/bisq/cli/table/column/ZippedStringColumns.java (130)
A cli/src/test/java/bisq/cli/AbstractCliTest.java (96)
A cli/src/test/java/bisq/cli/table/AddressCliOutputDiffTest.java (61)
A cli/src/test/java/bisq/cli/table/GetBalanceCliOutputDiffTest.java (42)
A cli/src/test/java/bisq/cli/table/GetOffersCliOutputDiffTest.java (126)
A cli/src/test/java/bisq/cli/table/GetTradeCliOutputDiffTest.java (52)
A cli/src/test/java/bisq/cli/table/GetTransactionCliOutputDiffTest.java (41)
A cli/src/test/java/bisq/cli/table/PaymentAccountsCliOutputDiffTest.java (39)
M core/src/main/java/bisq/core/api/CoreApi.java (6)
M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (21)
M daemon/src/main/java/bisq/daemon/grpc/GrpcPaymentAccountsService.java (3)
M proto/src/main/proto/grpc.proto (1)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/5812.patch
https://github.com/bisq-network/bisq/pull/5812.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5812
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211107/f8f21155/attachment-0001.htm>
More information about the bisq-github
mailing list