[bisq-network/bisq] Locked balance amount in menu bar is not consistent with "Locked Funds" tab (#5703)

[pazza]

Related to the above, here is an example of a trade that lead to a user having both:

- Locked funds shown in the GUI that were available in Funds > send funds
- Lost maker and miner fees when the reason for failure was taker tx id failing

<img width="845" alt="Screenshot 2021-11-07 at 11 45 33" src="https://user-images.githubusercontent.com/66367547/140663569-94efa6f3-2305-454d-9a85-d87348afdb05.png">

- Maker fee tx e50f64c325d63a0c2a2535c9cbc094322b102340d3246dc34ee8649c37d6eb31 on the chain
- Taker fee tx id is 08f13361a3780bd78ae800dfef6f7e1d890dcfd6ab9cf914f8d2539de46105dd  never made it to the 
- Deposit tx c9a1ff6ebc4e9a0a0b26ba6a5659e172cc0a32aa76f4f41f2d6e27192ce08182 never made it to the blockchain

I am hypothesizing that the creation of the deposit transaction ID leads Bisq to display Locked Funds incorrectly and also causing the loss of the maker / miner fees (when these could be reused for another trade).

I am assuming in the instance of taker transaction failing no deposit transaction would be created, trade would fail, no funds would be displayed as locked in GUI and trade would still be available for another user to take. 

Would it be possible so trades to fail due to a problem with the taker transaction to fail in the latter rather than former way?


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5703#issuecomment-962689673
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211107/a24f2851/attachment.htm>