[bisq-network/bisq] Extract persistence of BSQ blocks out of DaoStateStore [5] (PR #5790)

chimp1984 notifications at github.com
Tue Nov 9 13:15:33 CET 2021


@ripcurlx 
Re Codacy complaints: Unnecessary use of fully qualified name 'protobuf.BaseBlock' due to existing import 'protobuf.BaseBlock' 
I intentionally kept the protobuf package to make it clear that we dont use the java model here but the proto data.
So I prefer to keep it. I find those compaints anyway questionable. Leaving package qualifiers can help in certain context to improve readibility IMO. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5790#issuecomment-964097452
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211109/43549eb6/attachment-0001.htm>


More information about the bisq-github mailing list