[bisq-network/bisq] Changes required for GRIN re-listing (PR #5820)

jmacxx notifications at github.com
Wed Nov 10 21:43:31 CET 2021


- Changes GRIN altcoin account validation to use [SlatepackAddress](https://github.com/mimblewimble/grin-rfcs/blob/master/text/0015-slatepack.md#slatepackaddress) format.
- Update tests accordingly.
- Update the account creation popup text accordingly (see screenshots).
- See also: https://bisq.wiki/Trading_GRIN



https://github.com/bisq-network/proposals/issues/350
https://github.com/bisq-network/growth/issues/205#issuecomment-962480146

## Screenshots

### Account creation

![image](https://user-images.githubusercontent.com/47253594/141188938-40194bdf-6df1-4203-9742-f09d6b7a4d96.png)

### Account creation

![image](https://user-images.githubusercontent.com/47253594/141189257-19f502bc-f4fc-448e-a853-6ea99f6c7c6c.png)

### Account creation popup

![grin_account_popup](https://user-images.githubusercontent.com/47253594/141188615-2d416b1f-3d8f-48fb-a48e-34b13e79d4b7.png)

### Trade, start payment

![grin_payment_start](https://user-images.githubusercontent.com/47253594/141188634-5f742c62-ae52-44ed-aa0a-83a12b76631f.png)


### Trade, confirm payment received

![grin_confirm_payment](https://user-images.githubusercontent.com/47253594/141188646-de956d83-b62b-425d-a3ce-5214a65c7b06.png)




You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5820

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5820/commits/5bf7bba0c661ffecadc71962c2b13a12ec56f40a">Changes required for GRIN re-listing</a>

-- File Changes --

    D assets/src/main/java/bisq/asset/GrinAddressValidator.java (102)
    M assets/src/main/java/bisq/asset/coins/Grin.java (29)
    M assets/src/test/java/bisq/asset/coins/GrinTest.java (26)
    M core/src/main/resources/i18n/displayStrings.properties (10)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5820.patch
https://github.com/bisq-network/bisq/pull/5820.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5820
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211110/3d8f43ed/attachment.htm>


More information about the bisq-github mailing list