[bisq-network/bisq] Improve GRADLE build Performance (PR #5822)

[Chris Beams]

@cbeams requested changes on this pull request.

NACK. The change does not appear to improve build times; it rather appears to slow them down.

### Testing approach

I ran the following command three times each on HEAD of current master (A) and with this PR's patch applied (B).

```
$ time ./gradlew cleanCompileJava cleanCompileTestJava compileJava compileTestJava
```

Note that I had run several builds against the same daemon to fully warm it up before I started recording any of the runs.

## Results

### A
1. 1m 50s
2. 2m 05s
3. 1m 57s

### B
1. 2m 18s
2. 2m 08s
3. 2m 05s

So: at best, the build times in B could match A, but generally they were a bit longer. In fairness, the longest time (build B.1) of 2m 18s may be explained by the overhead necessary to spin up the compiler daemon for the first time. In any case, the results are not compelling.

## Notes

In future PRs, please do this kind of testing yourself and add notes like the above to demonstrate whether the improvement actually works. Thanks in any case.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5822#pullrequestreview-804578347
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211112/da28017f/attachment.htm>