[bisq-network/bisq] Add payment methods ACH Transfer and Domestic Wire Transfer (PR #5823)

[jmacxx]

Fixes https://github.com/bisq-network/growth/issues/219
Fixes https://github.com/bisq-network/growth/issues/218

- Makes use of existing `BankAccountPayload` having most of the fields already; adds `holder_address` in specializations.
- `AccountForm` code is shared between the two payment methods due to the similarity.
 

---

<details>
  <summary>Screenshots for ACH Transfer</summary>

### Account Creation

![ach_account_popup](https://user-images.githubusercontent.com/47253594/141508467-aa6e84eb-f93b-4851-9978-00e295e819c7.png)

![image](https://user-images.githubusercontent.com/47253594/141509393-c66d27fa-3847-48d1-9256-b0de73061266.png)


### Popup shown to Buyers

![ach_buyer_popup](https://user-images.githubusercontent.com/47253594/141508421-8c3fe7af-333b-4a2f-98c3-e0973eafe098.png)

### Popup shown to Sellers

![ach_seller_popup](https://user-images.githubusercontent.com/47253594/141508439-4f7dbb18-aba4-4129-b460-123def60f77c.png)

### Start Payment

![ach_start_payment](https://user-images.githubusercontent.com/47253594/141508385-bd63a4e2-9415-44dd-a654-e2972620bcf9.png)

### Confirm Payment

![ach_confirm_payment](https://user-images.githubusercontent.com/47253594/141508397-99308c14-e0ad-49a4-9c0a-952f70b098a4.png)
</details>

---

<details>
  <summary>Screenshots for Domestic Wire Transfer</summary>

### Account Creation

![domwire_account_popup](https://user-images.githubusercontent.com/47253594/141508556-08916e2c-5a83-4cfa-b84f-ae8fed2811a0.png)

![domwire_account](https://user-images.githubusercontent.com/47253594/141508535-a8da6916-173d-4d07-8fd8-3ce208ef38f5.png)

### Popup shown to Buyers

![domwire_buyer_popup](https://user-images.githubusercontent.com/47253594/141508578-59dfce50-6608-4b4a-bd1a-a85d5d30973f.png)

### Popup shown to Sellers

![domwire_seller_popup](https://user-images.githubusercontent.com/47253594/141508593-8f58fa27-a94e-4ee5-ba7c-b8d5cf3a6007.png)

### Start Payment

![domwire_start_payment](https://user-images.githubusercontent.com/47253594/141508607-e5a5d543-cc69-41da-91d3-c6060d610f98.png)

### Confirm Payment

![domwire_confirm_payment](https://user-images.githubusercontent.com/47253594/141508625-d2b14a15-803b-45ea-b12e-4b823570c10e.png)

### Trades

![image](https://user-images.githubusercontent.com/47253594/141509176-99ab8e42-57d6-44e1-8dda-598ee94447f6.png)

</details>

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5823

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5823/commits/43d99645124404cd495774ad692470f5c49acd35">Add payment methods ACH Transfer and Domestic Wire Transfer</a>

-- File Changes --

    A core/src/main/java/bisq/core/payment/AchTransferAccount.java (63)
    A core/src/main/java/bisq/core/payment/DomesticWireTransferAccount.java (63)
    M core/src/main/java/bisq/core/payment/PaymentAccountFactory.java (4)
    A core/src/main/java/bisq/core/payment/payload/AchTransferAccountPayload.java (115)
    A core/src/main/java/bisq/core/payment/payload/DomesticWireTransferAccountPayload.java (120)
    M core/src/main/java/bisq/core/payment/payload/PaymentMethod.java (6)
    M core/src/main/java/bisq/core/proto/CoreProtoResolver.java (6)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics3.java (4)
    M core/src/main/resources/i18n/displayStrings.properties (25)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/AchTransferForm.java (102)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/DomesticWireTransferForm.java (89)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/GeneralUsBankForm.java (171)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/TransferwiseUsdForm.java (3)
    M desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java (6)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (8)
    M proto/src/main/proto/pb.proto (10)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5823.patch
https://github.com/bisq-network/bisq/pull/5823.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5823
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211112/1377dfeb/attachment-0001.htm>