[bisq-network/bisq] Upgrade to Gradle 7.3 (PR #5824)

[Chris Beams]

This PR successfully upgrades the build from Gradle 6.6.1 to 7.3, but with a number of caveats that need to be worked out:

- [ ] Our Gradle Witness plugin fork needs to be updated such that it no longer depends on the now-removed `compile` configuration. The witness plugin has been disabled in the meantime, and it should be re-enabled when fixed.
- [ ] There is quite a bit of duplication now in repeated `implementation` dependency declarations, now that transitive `compile` declarations are no longer supported. This may be fine in the end (the explicitness is a good thing), but it's worth considering if we want to tidy them up in some way.
- [ ] The pricenode should be run and thoroughly tested, as its underlying Spring Boot dependency went through a major upgrade from 1.5.10-RELEASE => 2.5.6. As part of this upgrade, the `/getVersion` endpoint has been removed entirely. @bisq-network/pricenode-operators, is this endpoint something you actually use, or is it fine to remove?

Background: the reason I set out on this upgrade was part of the process of getting Bisq to build on an M1 Mac. That still appears impossible due to the bug in JFoenix. See https://github.com/cbeams/bisq/commit/3f4fba9 for details. In the meantime, building on an M1 Mac does work so long as you pass `-x :desktop:test`. Actually running the app, e.g. with `./gradlew :desktop:run`, however, does not and will not work until that bug is fixed. In any case, it will be easier to get Bisq building on M1 with this PR merged.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5824

-- Commit Summary --

  * WIP Upgrade to Gradle 7.3

-- File Changes --

    M build.gradle (366)
    M gradle/witness/gradle-witness.gradle (5)
    M gradle/wrapper/gradle-wrapper.properties (3)
    M pricenode/README.md (1)
    D pricenode/src/main/java/bisq/price/util/VersionController.java (55)
    D pricenode/src/test/java/bisq/price/util/VersionControllerTest.java (21)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5824.patch
https://github.com/bisq-network/bisq/pull/5824.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5824
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211112/43a843d6/attachment.htm>