[bisq-network/bisq] Fix calculation & display of Locked Funds (PR #5813)

[jmacxx]

The easiest consistent way to reproduce the locked up funds issue described in #5703, is by not signing one of the deposit transaction inputs causing it to be rejected by bitcoind.  Achieve that in test commenting out `TradeWalletService` L645-L646.

You end up with a trade that looks ok, but its deposit tx never gets a confirm.

At that point you'll decide to do an SPV resync, reconciling BitcoinJ state with the blockchain.  Upon restarting Bisq you'll encounter the following:

- Locked funds amount showing the trade deposit value.
- A popup which says the deposit tx has missing inputs.
- Red failed icons in the pending trades screen.
- Nothing shown in Funds -> Locked funds tab.

<details>
  <summary>Screenshots - click to expand</summary>

![failed_trade_popup_missing_deposit](https://user-images.githubusercontent.com/47253594/141606319-34439464-698f-474c-84de-1f6de9490475.png)


![failed_trade_locked_funds](https://user-images.githubusercontent.com/47253594/141606329-22993d71-cf85-4bbb-a13a-ffd803ebd493.png)

![failed_trade_details](https://user-images.githubusercontent.com/47253594/141606333-0014d1ae-de71-4a6b-823d-ef0cab9bffb9.png)


![failed_trade_move_to](https://user-images.githubusercontent.com/47253594/141606337-3ace45ce-d8e5-4686-b798-bdf5faa92c14.png)




</details>


Moving that trade to Failed Trades shows the dialog which says there are no locked funds, contradicting what is shown in the top right of the screen at Locked Funds display.

I re-did my testing to obtain these screenshots.

---

After the patch is applied, the Locked Funds no longer displays the fake locked amount.

**confirmed** deposit == locked funds.

![image](https://user-images.githubusercontent.com/47253594/141606573-446e2981-f7d1-4139-8a97-062fb3df71ee.png)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5813#issuecomment-967783998
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211112/33e598f4/attachment.htm>