[bisq-network/bisq] Improve fee handling (PR #5826)

[Christoph Atteneder]

@ripcurlx commented on this pull request.



> @@ -355,17 +431,69 @@ private Coin getTakerFeeRateBtc(long blockHeight) {
         return daoStateService.getParamValueAsCoin(Param.DEFAULT_TAKER_FEE_BTC, (int) blockHeight);
     }
 
+    private Optional<Boolean> maybeTestFeeFromFilter(Coin tradeAmount,

Maybe call it `maybeCheckAgainstFeeFromFilter`? `maybeTestFeeFromFilter` sounds a little bit weird to me (I'm no native speaker)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5826#pullrequestreview-805975238
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211115/94d290b8/attachment.htm>