[bisq-network/bisq] API 'getoffer' & 'gettrade' support for BSQ swaps (PR #5827)

Stan notifications at github.com
Tue Nov 16 14:16:08 CET 2021


> I tried `getoffer`, `getmyoffer`, `getoffers`, `getmyoffers`, `editoffer` and `gettrade`. `editoffer` fails as it is not implemented I guess, but `gettrade` also fails for bsq swap trades. Is this not to be expected to work in this PR as well?

I have not addressed the CLI side of this, and do not expect it to work.  (The PR title should have specified these are incremental changes, mostly on the server side.)  This will require 2-3 more PRs.

I am a bit surprised that `gettrade` did not work, but again, I have not worked on the CLI side of `gettrade`.

Please un-comment the `@Disabled` annotation in `bisq.apitest.method.trade.BsqSwapTradeTest`, and run it with the `-DrunApiTests=true` jvm-opt?  That should work because of the changes to the related gRPC/protobuf defs and classes, and other changes on the 'server' side.  To see what `gettrade` _will_ show (in future PR), set `<root level="DEBUG">` in the apitest/test/resources/logback.xml.  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5827#issuecomment-970263620
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211116/d8d16630/attachment.htm>


More information about the bisq-github mailing list