[bisq-network/bisq] Improve TradeStatistics validation (PR #5853)

[Stan]

@ghubstan commented on this pull request.



> @@ -437,7 +437,12 @@ public boolean isValid() {
         }
         long maxTradeLimit = Coin.COIN.multiply(2).value;
         try {
-            maxTradeLimit = PaymentMethod.getPaymentMethodById(getPaymentMethod()).getMaxTradeLimitAsCoin(currency).value;
+            // We cover only active payment methods. Retired ones will not be found by getActivePaymentMethodById.
+            String paymentMethod = getPaymentMethod();

`utACK` with a comment about line 441's var name not being `paymentMethodId`.  

It's clear from line 401's method declaration `public String getPaymentMethod()` that this is an ID (name).  But maybe line 401 could also be changed to `public String getPaymentMethodId()`?  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5853#pullrequestreview-813103770
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211122/95b51ad9/attachment.htm>