[bisq-network/bisq] Enforce inclusion of TradeLimits for headless apps (PR #5857)

chimp1984 notifications at github.com
Tue Nov 23 15:15:18 CET 2021


PaymentMethod use an instance of TradeLimits and expect that it
has been injected, which is the case for desktop but not for
headless apps, so we enforce injection in the app base classes
used for headless apps.

The validation of trade statistics use a method in PaymentMethod where that
dependency is required.

Tha hack how the PaymentMethod use TradeLimits is not nice, but
would require more effort for refactoring.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5857

-- Commit Summary --

  * Enforce inclusion of TradeLimits for headless apps

-- File Changes --

    M core/src/main/java/bisq/core/app/BisqHeadlessAppMain.java (6)
    M core/src/main/java/bisq/core/app/misc/ExecutableForAppWithP2p.java (8)
    M daemon/src/main/java/bisq/daemon/app/BisqDaemonMain.java (2)
    M seednode/src/main/java/bisq/seednode/SeedNodeMain.java (2)
    M statsnode/src/main/java/bisq/statistics/StatisticsMain.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5857.patch
https://github.com/bisq-network/bisq/pull/5857.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5857
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211123/187014fb/attachment.htm>


More information about the bisq-github mailing list