[bisq-network/bisq] Fix incorrect start height for block request (PR #5875)

[chimp1984]

We added 1 as with the lite monitor mode we persist the most recent block,
thus we request with the start height for the next block.
But that cause a problem at a DAO full mode which has lite monitor mode set
as then the block parsing would not be triggered.

We refactor it so that we take the chainHeight from the dao state
directly and add 1 at the requests.
We add a check if we are at chain tip, and if so we skip requests
and call the onParseBlockChainComplete directly.

How to test it?
Use a DAO full node and set lite mode for monitoring in setting. 
Create a new block. Restart. Now there is no BSQ and no monitoring data as block parsing did not get triggered.
With the PR this does not happen. 
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5875

-- Commit Summary --

  * Fix incorrect start height for block request

-- File Changes --

    M core/src/main/java/bisq/core/dao/node/BsqNode.java (20)
    M core/src/main/java/bisq/core/dao/node/full/FullNode.java (3)
    M core/src/main/java/bisq/core/dao/node/lite/LiteNode.java (18)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5875.patch
https://github.com/bisq-network/bisq/pull/5875.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5875
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211127/91a99892/attachment.htm>