[bisq-network/bisq] make all scripts executable (PR #5879)

Stephan Oeste notifications at github.com
Tue Nov 30 18:07:56 CET 2021


> `utACK`
> 
> Here are the scripts' perms in my clone of the branch:
> 
> ```
> -rwxrwxr-x 1 6.8K  create_dao_genesis.sh*
> -rwxrwxr-x 1 2.4K  install_java.bat*
> -rwxrwxr-x 1 3.9K  install_java_linux.sh*
> -rwxrwxr-x 1 1.7K  install_java_macos.sh*
> -rwxrwxr-x 1    0  install_java.sh*
> ```
> 
> I don't know if it matters, but I would have set them to `-rwxrw-r--`.

There is no harm it it.
Also I think `-rwxrwxr-x` is needed. 
The checkout will be made by a normal user, but you will install Java as root. I think at least the seednode install script is doing it that way.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5879#issuecomment-982838272
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211130/a0ea18e6/attachment.htm>


More information about the bisq-github mailing list