[bisq-network/bisq] Move volume formatting from DisplayUtils to VolumeUtil (#5740)

[Stan]

In practice, presentation/display logic should be kept in UIs, but the core api will need to duplicate a very small part of the code in `DisplayUtils` if a very small part of this refactoring is not done.  Instead of moving a tiny bit of the volume formatting methods, all of them are moved to core's `VolumeUtil`.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5740

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5740/commits/db6e2a51b2243c84a0be7cef7ae012d348359c1d">Move volume formatting from DisplayUtils to VolumeUtil</a>

-- File Changes --

    M core/src/main/java/bisq/core/util/VolumeUtil.java (83)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java (6)
    M desktop/src/main/java/bisq/desktop/main/market/MarketView.java (3)
    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java (67)
    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModel.java (21)
    M desktop/src/main/java/bisq/desktop/main/market/trades/TradeStatistics3ListItem.java (5)
    M desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java (3)
    M desktop/src/main/java/bisq/desktop/main/market/trades/charts/volume/VolumeBar.java (4)
    M desktop/src/main/java/bisq/desktop/main/offer/FeeUtil.java (7)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java (8)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java (3)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java (3)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/ContractWindow.java (62)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java (3)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/OfferDetailsWindow.java (19)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/SwiftPaymentDetails.java (9)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/TradeDetailsWindow.java (5)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java (7)
    M desktop/src/main/java/bisq/desktop/main/portfolio/failedtrades/FailedTradesViewModel.java (6)
    M desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersViewModel.java (5)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java (5)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (3)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java (28)
    M desktop/src/main/java/bisq/desktop/util/DisplayUtils.java (83)
    M desktop/src/main/java/bisq/desktop/util/GUIUtil.java (7)
    M desktop/src/test/java/bisq/desktop/util/DisplayUtilsTest.java (15)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5740.patch
https://github.com/bisq-network/bisq/pull/5740.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5740
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211002/fa4b5f01/attachment.htm>