[bisq-network/bisq] Refactor desktop Closed Tradable model utils for API (#5743)

[Stan]

Move some potentially shareable utility code from desktop's ClosedTrade models to core's new `ClosedTradeUtil`.

The API's `gettrades --category=<open|closed|failed>` method will need some of this logic on the server side, but the scope of the refactoring is larger in the interest of completeness, and avoiding duplication in the future.


This PR's branch is based off `master`, and is not part of any PR chain requiring review/merge of any parent PRs.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5743

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5743/commits/999c4a516dc20d1f1a7bd5ea3da922e5c0bb4ffd">Refactor desktop Closed Tradable model utils for API use</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5743/commits/738d22fbdfcc691babdb735aa44f8bf9d555d438">Rename method, add static import</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5743/commits/fae72883855a70f8c993091f7c08baad48f8101b">Adjust to renamed method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5743/commits/30135177f86563ffc07e8c5542d558e692937092">Remove transitive javafx.collections dependency</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5743/commits/5f521068eaaa2613fd463ab09d35da7aa97b8d70">Remove unused PriceFeedService</a>

-- File Changes --

    A core/src/main/java/bisq/core/trade/closed/ClosedTradeUtil.java (390)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesDataModel.java (117)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java (239)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5743.patch
https://github.com/bisq-network/bisq/pull/5743.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5743
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211005/f1b3a4c2/attachment-0001.htm>