[bisq-network/bisq] Fix issue of Trade Step 1 validation done too soon (#5746)

chimp1984 notifications at github.com
Mon Oct 11 19:09:20 CEST 2021


> To also prevent the initial red failed icons in Open Trades list, something like this would do it, what do you think?
> 
> PendingTradesView.java L370:
> 
> ```
> private boolean isMaybeInvalidTrade(Trade trade) {
>     return trade.hasErrorMessage() ||
>             (Trade.Phase.DEPOSIT_PUBLISHED.ordinal() <= trade.getPhase().ordinal() && trade.isTxChainInvalid());
> }
> ```

Looks ok to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5746#issuecomment-940204576
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/b0654b8f/attachment.htm>


More information about the bisq-github mailing list