[bisq-network/bisq] Version string is missing in bitcoin P2P protocol on Bisq 1.7.4 (#5757)

Stephan Oeste notifications at github.com
Fri Oct 15 19:18:15 CEST 2021


<!--
   SUPPORT REQUESTS: This is for reporting bugs in the Bisq app.
   If you have a support request, please join #support on Bisq's
   Keybase team over at https://keybase.io/team/Bisq
-->

### Description

<!-- brief description of the bug -->
In version 1.7.4 with Tor v3 support is the version string in the Bitcoin P2P protocol missing.
The impact is minimal, it just shows up as an empty string. But for statistics it would be good to have the Bisq version shown in the P2P.

#### Version
1.7.4

<!-- commit id or version number -->



### Steps to reproduce
Connet your Bisq client to your Bitcoin node and execute on your Bitcoin node:
```bitcoin-cli getpeerinfo``` and look for the subver key.

<!--if you can reliably reproduce the bug, list the steps here  -->


### Expected behaviour
    "subver": "/bitcoinj:0.?.?.bisq.?/Bisq:1.7.4/"

<!--description of the expected behavior -->

### Actual behaviour

     "subver": ""

<!-- explain what happened instead of the expected behaviour -->

### Screenshots
Output from one of my Bitcoin trusted nodes:
```
$ bitcoin-cli getpeerinfo | grep subver | sort | uniq -c | sort -n
      2     "subver": "/bitcoinj:0.15.8.bisq.13/Bisq:1.6.5/",
      3     "subver": "/bitcoinj:0.15.8.bisq.13/Bisq:1.7.0/",
      3     "subver": "/bitcoinj:0.15.9.bisq.14/Bisq:1.7.4/",
      4     "subver": "/bitcoinj:0.15.8.bisq.13/Bisq:1.6.2/",
      9     "subver": "/bitcoinj:0.15.8.bisq.13/Bisq:1.7.2/",
     14     "subver": "/bitcoinj:0.15.8.bisq.13/Bisq:1.7.3/",
     21     "subver": "/Satoshi:0.21.1/",
     23     "subver": "/Satoshi:22.0.0/",
    169     "subver": "",

```
<!--Screenshots if gui related, drag and drop to add to the issue -->

#### Device or machine

<!-- device/machine used, operating system -->



#### Additional info

<!-- Additional information useful for debugging (e.g. logs) -->


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5757
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211015/9b7c5528/attachment-0001.htm>


More information about the bisq-github mailing list