[bisq-network/roles] Comptroller (Issue #111)

[Chris Beams]

Great to see this come together @pazza83.

A few items of feedback, in no particular order:

- I would, in principle, see this as an @bisq-network/admin role as opposed to @bisq-network/support, but for practical purposes, I agree it should be managed under support. @leo816, are you OK with reviewing and approving @pazza83's compensation requests relating to this role?

- The compensation amount requested looks reasonable to me. Certainly worth it to have ongoing profit and loss numbers.

- I like the simple breakdown of numbers you've started with here. I think it would be worth having a single rolled up, USD denominated revenue number that sums up the BSQ and BTC revenue numbers above, but this is a minor point.

- It would be good to see the actual BSQ number in the BSQ trade revenue fees line item. Same with contributor costs. Since these are actually denominated in BSQ, it would be good to see a third column "BSQ" that lists these values. Perhaps you could **bold** the values for each row that represent the original denomination.

- the link to the spreadsheet above is broken.

- In the table above, ((BSQ trade revenue fees + BTC trade revenue fees) - Contributor costs) = Net Profit (Loss), but the actual values in the table do not add up. (($8,562+$35,096) - $17,351) = **$26,307**, but the total listed above is **$26,790**. This is a minor discrepancy, but it makes me wonder what's missing from the table and/or spreadsheet that led to this.

In any case, I think this is a good start, and if all we do with this role is apply the same methodology to produce the same set of numbers every month, that'll already be a massive improvement. Thanks for taking it on @pazza83.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/111#issuecomment-946140499
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/773e6213/attachment.htm>