[bisq-network/bisq] Avoid that outdated donation and fee addresses are used. (PR #5764)

[jmacxx]

@jmacxx requested changes on this pull request.



> @@ -34,12 +32,16 @@
 
 @Slf4j
 public class FeeReceiverSelector {
-    public static String getAddress(DaoFacade daoFacade, FilterManager filterManager) {
-        return getAddress(daoFacade, filterManager, new Random());
+    public static String getMostRecentAddress() {
+        return "38bZBj5peYS3Husdz7AH3gEUiUbYRD951t";

This fails when run in regtest, suggest something like this:

    public static String getMostRecentAddress() {
        return Config.baseCurrencyNetwork().isMainnet() ? Config.LATEST_DONATION_ADDRESS :  // mainnet
                Config.baseCurrencyNetwork().isDaoBetaNet() ? Config.LATEST_DONATION_ADDRESS : // daoBetaNet
                        Config.baseCurrencyNetwork().isTestnet() ? Config.TESTNET_DONATION_ADDRESS : // testnet
                                Config.REGTEST_DONATION_ADDRESS; // regtest
    }


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5764#pullrequestreview-784996831
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/2c2b2d58/attachment.htm>