[bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR #5770)
Stan
notifications at github.com
Fri Oct 22 18:49:34 CEST 2021
@ghubstan commented on this pull request.
> @@ -96,7 +95,7 @@
///////////////////////////////////////////////////////////////////////////////////////////
@Getter
- private final OfferPayload offerPayload;
+ private final OfferPayloadBase offerPayloadBase;
It's odd to me that `Offer`'s payload is an instance of an abstract class, instead of an `OfferPayload`. I'm a little confused but understand `Offer` might have an `OfferPayloadBase` (not an `OfferPayload`) due to the incremental refactoring towards supporting BSQ swaps.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-787072570
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211022/5d270054/attachment.htm>
More information about the bisq-github
mailing list