[bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR #5770)

[Stan]

@ghubstan commented on this pull request.



> @@ -96,7 +96,7 @@ public static TradeStatistics2 from(Trade trade,
         Offer offer = trade.getOffer();
         checkNotNull(offer, "offer must not ne null");
         checkNotNull(trade.getTradeAmount(), "trade.getTradeAmount() must not ne null");
-        OfferPayload offerPayload = offer.getOfferPayload();
+        OfferPayload offerPayload = offer.getOfferPayload().orElseThrow();

```
.orElseThrow(() ->
                new IllegalStateException(format("Offer %s has no payload.", openOffer.getId())));

```
?

Resolve these remarks when annoyed ;-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-787093927
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211022/7d21788e/attachment.htm>