[bisq-network/bisq] Include holder name field for Monese & Satispay accounts (PR #5791)

jmacxx notifications at github.com
Sun Oct 31 22:07:23 CET 2021


#5745 added Monese & Satispay account types, but by mistake the `holder_name` field was left out of the UI.



Ref: https://github.com/bisq-network/growth/issues/227#issuecomment-955606039
Ref: https://github.com/bisq-network/growth/issues/213#issuecomment-955606677


This PR adds the missing field to the UI.  If a Monese or Satispay accound was created previously, the `holder_name` field will be blank and the user should create a new account.  (As Monese & Satispay are new and therefore not aged I do not think it necessary to implement an account upgrade procedure).



---


![image](https://user-images.githubusercontent.com/47253594/139601213-4af59fbf-a945-43c7-9e6e-37bbb527aba5.png)

 

![image](https://user-images.githubusercontent.com/47253594/139601221-af466a22-fb31-4066-a2f9-d5a15f1d9cf5.png)

 

![image](https://user-images.githubusercontent.com/47253594/139601084-b815fb4d-210f-4c2f-a7a2-394c7200f271.png)

 

![image](https://user-images.githubusercontent.com/47253594/139601146-b7ea6c56-77ba-4bc6-ad21-8ca2a28f7beb.png)


 


@pazza83 :eyes: 
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5791

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5791/commits/aead47721b4bcf6643af55557d988de1754e4629">Include owner name for Monese & Satispay accounts</a>

-- File Changes --

    M core/src/main/java/bisq/core/payment/MoneseAccount.java (8)
    M core/src/main/java/bisq/core/payment/SatispayAccount.java (8)
    M core/src/main/java/bisq/core/payment/payload/MoneseAccountPayload.java (12)
    M core/src/main/java/bisq/core/payment/payload/SatispayAccountPayload.java (13)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneseForm.java (22)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/SatispayForm.java (25)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5791.patch
https://github.com/bisq-network/bisq/pull/5791.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5791
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/2cfd741e/attachment.htm>


More information about the bisq-github mailing list