[bisq-network/bisq] japanese.validation.regex should accept U+3007 (#5688)
notifications at github.com
Fri Sep 10 08:03:54 CEST 2021
SUPPORT REQUESTS: This is for reporting bugs in the Bisq app.
If you have a support request, please join #support on Bisq's
Keybase team over at https://keybase.io/team/Bisq
`JapanBankData.getString("japanese.validation.regex")` only lets kanji/kana pass. As a kanji, currently `U+4E00` … `U+9FAF` will be seen as valid (according to `JapanBankData.java`), which may be practically good enough. However, there is one special character out of the above range that should be also accepted. Namely:
`U+3007` [ 〇 ] IDEOGRAPHIC NUMBER ZERO
This letter (the kanji version of number 0) is used in many branch names of a specific Japanese bank. Thus one should add the following to that RegEx:
"〇" + // IDEOGRAPHIC NUMBER ZERO (0x3007)
### Steps to reproduce
As a test, try to input a random (hypothetical) Japanese Bank account info, with a branch name e.g. "〇一二". This branch name is well-formed but will be refused with an error message.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github