[bisq-network/bisq] Support XMR<->BTC trading via API (#5691)
Stan
notifications at github.com
Sun Sep 12 01:47:25 CEST 2021
Also added new API trading simulation script: `apitest/scripts/trade-xmr-simulation.sh`.
This is the 4th in a series of PRs starting with https://github.com/bisq-network/bisq/pull/5685.
https://github.com/bisq-network/bisq/pull/5690 should be reviewed & merged before this one.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/5691
-- Commit Summary --
* Wrap long i18n strings for use in API
* Format comments, add one
* Replace growing # of instanceof checks with boolean hasPaymentMethodWithId
* Adjust to PaymentAccount changes in commit de23fc0
* Do single trade currency check in api generated payment acct
* Adjust to PaymentAccount change in commit de23fc0
* Let users specify trade ccys and selected trade ccy in json form
* Do pay acct ccy checks, add tests, anticipate swift pay method
* Remove spurious `PaymentAccount#canSupportMultipleCurrencies()`
* Set apitest test case log level to INFO
* Define toString method
* Adjust for XMR support
* Refactor for supporting creation of XMR accounts via API
* Refactor for supporting creation of XMR accounts via API
* Add create bsq & xmr payment acct test cases
* Don't run method test 2x from gradle
* Merge branch 'master' into 2-create-xmr-payment-accts-via-api
* Remove unused fields
* Update createoffer help text with BSQ & XMR examples
* Adjust gRPC client & CLI opt parsers for XMR support
* Update required JDK version and target source version
* Test create and edit XMR offers via API
* Adjust for xmr support
* Minor refactor / remove a bit of duplication
* Fill out / refactor CLI getoffers smoke test
* Make codacy happy
* Adjust for XMR (more generic) altcoin support in API
* Add XMR/BTC trade pair tests & refactor trade tests
* Adjust trade-simulation-utils.sh for altcoin trading
* Add parsexmrscriptopts function
* Update JDK requirement comment, fix typo
* Add trade-xmr-simulation script
* Fix fee-currency spec error, adjust description
* Make xmr address var local, not global
-- File Changes --
M apitest/docs/api-beta-test-guide.md (2)
M apitest/scripts/trade-simulation-env.sh (38)
M apitest/scripts/trade-simulation-utils.sh (10)
M apitest/scripts/trade-simulation.sh (4)
A apitest/scripts/trade-xmr-simulation.sh (124)
M apitest/src/main/java/bisq/apitest/config/ApiTestConfig.java (4)
M apitest/src/test/java/bisq/apitest/method/MethodTest.java (11)
M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (20)
M apitest/src/test/java/bisq/apitest/method/offer/CreateBSQOffersTest.java (4)
M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (7)
A apitest/src/test/java/bisq/apitest/method/offer/CreateXMROffersTest.java (180)
M apitest/src/test/java/bisq/apitest/method/offer/EditOfferTest.java (263)
M apitest/src/test/java/bisq/apitest/method/payment/AbstractPaymentAccountTest.java (106)
M apitest/src/test/java/bisq/apitest/method/payment/CreatePaymentAccountTest.java (302)
M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (163)
M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (165)
M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (155)
M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferWithNationalBankAcctTest.java (152)
A apitest/src/test/java/bisq/apitest/method/trade/TakeBuyXMROfferTest.java (184)
M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBSQOfferTest.java (161)
M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (148)
A apitest/src/test/java/bisq/apitest/method/trade/TakeSellXMROfferTest.java (186)
M apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java (40)
M apitest/src/test/java/bisq/apitest/scenario/OfferTest.java (18)
M apitest/src/test/java/bisq/apitest/scenario/PaymentAccountTest.java (14)
M apitest/src/test/java/bisq/apitest/scenario/TradeTest.java (48)
A apitest/src/test/resources/logback.xml (20)
M cli/src/main/java/bisq/cli/CliMain.java (7)
M cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (2)
M cli/src/main/java/bisq/cli/CryptoCurrencyUtil.java (5)
M cli/src/main/java/bisq/cli/GrpcClient.java (12)
M cli/src/main/java/bisq/cli/TradeFormat.java (29)
M cli/src/main/java/bisq/cli/opts/CreateCryptoCurrencyPaymentAcctOptionParser.java (15)
M cli/src/main/java/bisq/cli/opts/CreateOfferOptionParser.java (4)
M cli/src/main/java/bisq/cli/opts/GetOffersOptionParser.java (2)
M cli/src/main/java/bisq/cli/request/OffersServiceRequest.java (35)
M cli/src/test/java/bisq/cli/GetOffersSmokeTest.java (82)
M cli/src/test/java/bisq/cli/opts/OptionParsersTest.java (12)
M common/src/main/java/bisq/common/util/Utilities.java (16)
M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (58)
M core/src/main/java/bisq/core/api/CoreWalletsService.java (11)
M core/src/main/java/bisq/core/api/model/PaymentAccountForm.java (8)
M core/src/main/java/bisq/core/api/model/PaymentAccountTypeAdapter.java (141)
M core/src/main/java/bisq/core/locale/Res.java (28)
M core/src/main/java/bisq/core/offer/CreateOfferService.java (4)
M core/src/main/java/bisq/core/payment/PaymentAccount.java (20)
M core/src/main/java/bisq/core/payment/payload/AssetsAccountPayload.java (13)
M core/src/main/resources/help/createcryptopaymentacct-help.txt (16)
M core/src/main/resources/help/createoffer-help.txt (36)
M core/src/main/resources/help/takeoffer-help.txt (4)
M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java (13)
M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java (5)
M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java (31)
M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferDataModel.java (5)
M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java (14)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/5691.patch
https://github.com/bisq-network/bisq/pull/5691.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5691
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210911/f5c5549e/attachment.htm>
More information about the bisq-github
mailing list