[bisq-network/bisq] Community tab (#5680)

Christoph Atteneder notifications at github.com
Mon Sep 13 09:36:54 CEST 2021


@xyzmaker123 Thanks for your PR. Just a couple of remarks on the UI Code. Please try to use the AutoTooltip... components instead of the JFX.. default ones. So it will automatic truncate and provide a tooltip if a translation won't fit into the boundaries. The other thing is we try to not use FXML syntax whenever possible as it is bad for performance. So we normally just have a main container as an entry point and instantiate all other UI components manually. And yes, there are still some legacy FXML UIs (network..) out there which would need some dev love. :wink:

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5680#issuecomment-917922723
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210913/fa05a133/attachment.htm>


More information about the bisq-github mailing list