[bisq-network/bisq] japanese.validation.regex should accept U+3007 (#5688)
notifications at github.com
Tue Sep 14 09:16:34 CEST 2021
> @ripcurlx Yeah, you're right. I wish I had more time. The code change itself is looking good. While double-checking I noticed some other unimportant issues around there, though everything works fine as-is.
> 1. These two lines are almost identical and so mostly redundant:
> `"ぁ-ゔ" + // full-width hiragana (0x3041 ~ 0x3094)`
> `"ぁ-ゞ" + // half-width hiragana` (0x3041 ~ 0x309e)
> One could simplify the above two lines as one line:
> `"ぁ-ゞ" + // hiragana (0x3041 ~ 0x309e)`
> Note, Unicode hiragana is always full-width, there's no "half-width hiragana" afaik.
> 2. The comment is incorrect in this line, which includes 5 code points, not 4:
> `"ヽヾ゛゜ー" + // 0x309e, 0x309b, 0x309c, 0x30fc`
> The first two code points are:
> U+30FD [ ヽ ] KATAKANA ITERATION MARK
> U+30FE [ ヾ ] KATAKANA VOICED ITERATION MARK
> So you can change `0x309e` to `0x30fd, 0x30fe`. The other three (`0x309b, 0x309c, 0x30fc`) are fine as-is.
Just pushed the changes. Could you please have a look at it and utACK or ACK the PR in a comment? Thanks!
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github