[bisq-network/bisq] Add five Indian payment methods (#5696)

jmacxx notifications at github.com
Wed Sep 15 22:59:30 CEST 2021


- [x] **PayTM**
Closes https://github.com/bisq-network/growth/issues/226
Screenshots for PayTM implementation:
https://gist.github.com/jmacxx/2bcf95607373c821990e82bdcfa2c3fd#gistcomment-3894407

- [x] **UPI**
Closes https://github.com/bisq-network/growth/issues/225
Screenshots for UPI implementation:
https://gist.github.com/jmacxx/5d9dbdc80a7ad9e8b5847be548ed9b99#gistcomment-3894411

- [x] **RTGS**
Closes https://github.com/bisq-network/growth/issues/237
Screenshots for RTGS implementation:
https://gist.github.com/jmacxx/0dab93fb6dcda158dd930c0ed4120290#gistcomment-3894416

- [x] **NEFT**
Closes https://github.com/bisq-network/growth/issues/236
Screenshots for NEFT implementation:
https://gist.github.com/jmacxx/61df5ac79581bd4a6e8458a998762063#gistcomment-3894447

- [x] **IMPS**
Closes https://github.com/bisq-network/growth/issues/224
Screenshots for IMPS implementation:
https://gist.github.com/jmacxx/fd60d9f343e88f3d3b806a2d893be487#gistcomment-3894453


----

### Note to reviewers:

All payment methods are specific to India / INR currency and are implemented using `CountryBasedPaymentAccount`.

Three of the payment methods (RTGS/NETF/IMPS) are payment networks which use [IFS Code](https://www.theifsccode.com/) and account number as the payee id.  Since they function the same, code re-use was attained by inheriting from `IfscBasedAccountPayload` and using `IfscBankForm` to do the common GUI work.

The other two payment methods (PayTM, UPI) are regular single field payId accounts.


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5696

-- Commit Summary --

  * Add five Indian payment methods

-- File Changes --

    A core/src/main/java/bisq/core/payment/ImpsAccount.java (36)
    A core/src/main/java/bisq/core/payment/NeftAccount.java (36)
    M core/src/main/java/bisq/core/payment/PaymentAccountFactory.java (10)
    A core/src/main/java/bisq/core/payment/PaytmAccount.java (44)
    A core/src/main/java/bisq/core/payment/RtgsAccount.java (36)
    A core/src/main/java/bisq/core/payment/UpiAccount.java (44)
    A core/src/main/java/bisq/core/payment/payload/IfscBasedAccountPayload.java (96)
    A core/src/main/java/bisq/core/payment/payload/ImpsAccountPayload.java (115)
    A core/src/main/java/bisq/core/payment/payload/NeftAccountPayload.java (115)
    M core/src/main/java/bisq/core/payment/payload/PaymentMethod.java (19)
    A core/src/main/java/bisq/core/payment/payload/PaytmAccountPayload.java (99)
    A core/src/main/java/bisq/core/payment/payload/RtgsAccountPayload.java (115)
    A core/src/main/java/bisq/core/payment/payload/UpiAccountPayload.java (99)
    M core/src/main/java/bisq/core/proto/CoreProtoResolver.java (23)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics3.java (7)
    M core/src/main/resources/i18n/displayStrings.properties (23)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/IfscBankForm.java (132)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/ImpsForm.java (38)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/NeftForm.java (38)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/PaytmForm.java (106)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/RtgsForm.java (38)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/UpiForm.java (106)
    M desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java (15)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (20)
    M proto/src/main/proto/pb.proto (31)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5696.patch
https://github.com/bisq-network/bisq/pull/5696.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5696
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210915/27f4b7be/attachment.htm>


More information about the bisq-github mailing list