[bisq-network/bisq] Trade payout address was reused from prior trade & no funds received (#5725)

[jmacxx]

Buy trade, maker: `czcgg`.  Upon clicking "Payment started", the trade immediately transitioned to complete, although the seller had not yet acknowledged payment receipt.  

Investigation showed that the trade obtained the same payout address as a prior trade done an hour earlier.  Therefore the payout address listener found funds (from the prior trade) - this indicated to Bisq that the trade was complete.

The code in Bisq explicitly requests an unused address, ultimately relying on BitcoinJ for that.

An unused payout address is requested at trade initiation:
https://github.com/bisq-network/bisq/blob/484998815c7e15d32b5845e53c907289eee974e3/core/src/main/java/bisq/core/trade/protocol/tasks/maker/MakerSendsInputsForDepositTxResponse.java#L62

https://github.com/bisq-network/bisq/blob/484998815c7e15d32b5845e53c907289eee974e3/core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java#L668-L672

https://github.com/bisq-network/bisq/blob/484998815c7e15d32b5845e53c907289eee974e3/core/src/main/java/bisq/core/btc/wallet/WalletService.java#L545-L546

https://github.com/bisq-network/bisq/blob/484998815c7e15d32b5845e53c907289eee974e3/core/src/main/java/bisq/core/btc/wallet/WalletService.java#L529-L542

https://github.com/bisq-network/bitcoinj/blob/3186b200fff690fa51f3ebbf578f427d78242bc2/core/src/main/java/org/bitcoinj/wallet/Wallet.java#L3000-L3009



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5725
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210925/07aa88b1/attachment.htm>