[bisq-network/bisq] [WIP] Atomic bsq trades (#5729)

[Christoph Atteneder]

@ripcurlx commented on this pull request.



> @@ -425,7 +426,7 @@ private long getTradeLimit(Coin maxTradeLimit,
                                PaymentMethod paymentMethod) {
         if (CurrencyUtil.isCryptoCurrency(currencyCode) ||
                 !PaymentMethod.hasChargebackRisk(paymentMethod, currencyCode) ||
-                direction == OfferPayload.Direction.SELL) {
+                direction == OfferPayloadI.Direction.SELL) {

The naming of the interface `OfferPayloadI` somehow feels weird. How about calling the interface `OfferPayload` and the implementation `OfferPayloadImpl` and coding as much as possible against the interface? Or call the implementation something other more specific (I'm to early in the commits to suggest something better - `OfferWithFeePayload`?)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5729#pullrequestreview-765141482
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210928/9fe9eec8/attachment.htm>